Allow a custom set of characters in a token #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
reviewed
Oct 4, 2019
| @@ -114,7 +114,8 @@ class BooleanAlgebra(object): | |||
| """ | |||
|
|
|||
| def __init__(self, TRUE_class=None, FALSE_class=None, Symbol_class=None, | |||
| NOT_class=None, AND_class=None, OR_class=None): | |||
| NOT_class=None, AND_class=None, OR_class=None, | |||
| allowed_in_token=('.', ':', '_')): | |||
There was a problem hiding this comment.
Could it be better to provide a string that lists all allowed characters explicitly (including "alnum")?
There was a problem hiding this comment.
The idea is good, but maybe not practical to match what alnum allows? According to the python docs, isalpha (part of alnum) matches any unicode character marked as 'Letter'. I'm not sure how many that is exactly, but probably more than one would want to specify.
There was a problem hiding this comment.
Good point. Using a string vs a list is minor too. So I am merging as-is.
Thank you again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposed way to handle issue #86.