Resolve sonar recommendations

Closes #92
baynezy · Feb 12, 2024 · 4afe3f7 · 4afe3f7
1 parent 55b8973
commit 4afe3f7
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 3 deletions.
diff --git a/.idea/.idea.NHSNumberGenerator/.idea/sonarlint.xml b/.idea/.idea.NHSNumberGenerator/.idea/sonarlint.xml
diff --git a/...HSNumberGenerator/.idea/sonarlint/issuestore/b/3/b31980982ecfe9ba85602c94442d1b4a21c6493b b/...HSNumberGenerator/.idea/sonarlint/issuestore/b/3/b31980982ecfe9ba85602c94442d1b4a21c6493b
diff --git a/.idea/.idea.NHSNumberGenerator/.idea/sonarlint/issuestore/index.pb b/.idea/.idea.NHSNumberGenerator/.idea/sonarlint/issuestore/index.pb
diff --git a/...nerator/.idea/sonarlint/securityhotspotstore/b/3/b31980982ecfe9ba85602c94442d1b4a21c6493b b/...nerator/.idea/sonarlint/securityhotspotstore/b/3/b31980982ecfe9ba85602c94442d1b4a21c6493b
diff --git a/.idea/.idea.NHSNumberGenerator/.idea/sonarlint/securityhotspotstore/index.pb b/.idea/.idea.NHSNumberGenerator/.idea/sonarlint/securityhotspotstore/index.pb
diff --git a/src/NHSNumberGenerator/Generator.cs b/src/NHSNumberGenerator/Generator.cs
@@ -14,7 +14,7 @@ public static string Generate()
         return number.Calculate();
     }
 
-    private class NhsNumber
+    private sealed class NhsNumber
     {
 
         private readonly Random _random = new();
@@ -51,13 +51,13 @@ private int RandomDigit()
             return _random.Next(0, 10);
         }
 
-        private class NumberPart
+        private sealed class NumberPart
         {
             internal int Number { get; init; }
 
             internal int Factor { get; init; }
 
-            public int Calculate()
+            internal int Calculate()
             {
                 return Number * Factor;
             }