Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go dependencies #216

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Update go dependencies #216

merged 5 commits into from
Dec 13, 2023

Conversation

stevebarrau
Copy link
Collaborator

This should resolve #211 for good.

The java dependencies changes are caused by a run of ./tools/update-dependencies.sh.

@stevebarrau stevebarrau requested review from shs96c and illicitonion and removed request for illicitonion October 23, 2023 12:44
@stevebarrau stevebarrau mentioned this pull request Oct 23, 2023
Closed
shs96c
shs96c approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work, but it feels like a bit of a hack. Approved.

@ar3s3ru ar3s3ru mentioned this pull request Dec 6, 2023
Closed
@stevebarrau stevebarrau force-pushed the deps/update-go-deps branch 5 times, most recently from 7f571d9 to 4676e75 Compare December 12, 2023 11:40
stevebarrau
stevebarrau commented Dec 12, 2023
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
stevebarrau
stevebarrau commented Dec 12, 2023
View reviewed changes
repositories.bzl Outdated Show resolved Hide resolved
@stevebarrau stevebarrau force-pushed the deps/update-go-deps branch 2 times, most recently from 773d805 to cccbf86 Compare December 12, 2023 12:19
stevebarrau
stevebarrau commented Dec 12, 2023
View reviewed changes
MODULE.bazel Outdated Show resolved Hide resolved
stevebarrau
stevebarrau commented Dec 12, 2023
View reviewed changes
WORKSPACE Show resolved Hide resolved
@stevebarrau stevebarrau mentioned this pull request Dec 13, 2023
Closed
@stevebarrau
Copy link
Collaborator Author

Ideally we should wait for bazel-contrib/bazel-gazelle#1686 to merge before landing this PR.

@stevebarrau
Copy link
Collaborator Author

Ideally we should wait for bazelbuild/bazel-gazelle#1686 to merge before landing this PR.

This is not required in the end. This is already addressed in 0.33+ of gazelle.

illicitonion
illicitonion approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@illicitonion illicitonion merged commit e41a109 into bazel-contrib:main Dec 13, 2023
2 checks passed
@stevebarrau stevebarrau deleted the deps/update-go-deps branch December 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illicitonion illicitonion illicitonion approved these changes

@shs96c shs96c shs96c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to find javaparser in runfiles
3 participants
@stevebarrau @shs96c @illicitonion