Adds several attributes to spotbugs rule #298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shs96c
requested changes
Oct 21, 2024
| # so that we can pass a glob. In cases where no baseline file exist, the glob will simply | ||
| # be empty. Using a label instead of a label_list would force us to create a baseline file | ||
| # for all targets, even if theres no need for one. | ||
| "baseline_file": attr.label_list( |
There was a problem hiding this comment.
Please just make this an attr.label, and you don't need to set the default since it will automatically be None. The check that's if len(baseline_files) > 0: will then just be if ctx.attr.baseline_file: which will be fine.
The logic of this statement is also incorrect if --incompatible_disallow_empty_glob is set, so I'm not sure this is really helping.
|
Hi @sfc-gh-mgalindo, I'd love to be able to merge this in, but there's one change requested. Would you please be able to make it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several attributes to the spotbugs rule to allow customizing the spotbugs invocation.
Specifically adds