Do not pass default values of kotlinc options. #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bencodes
reviewed
May 16, 2023
| load("@bazel_skylib//lib:unittest.bzl", "analysistest", "unittest") | ||
| load(":opts.kotlinc.bzl", "KotlincOptions", "kotlinc_options_to_flags") | ||
|
|
||
| def _kt_kotlinc_options_test_impl(ctx): |
There was a problem hiding this comment.
Shouldn't this be in the test directory, maybe near https://github.com/bazelbuild/rules_kotlin/blob/master/src/test/starlark/convert_test.bzl?
Bencodes
reviewed
May 16, 2023
|
|
||
| flags = [] | ||
| for n, o in opts.items(): | ||
| value = getattr(attr_provider, n, None) | ||
| if value == o.args["default"]: |
There was a problem hiding this comment.
Is this logic comparing the input value on the user defined kt_kotlinc_options target to the default attr value specified in the opts value, and skipping if true?
Bencodes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.