24456 Updated "disable non BEN corps" functionality (new FF) (#706)

- app version = 7.4.8
- changed isDisableNonBenCorps computation
- added FF 'businesses-to-manage-in-colin'
- deleted FF 'enable-non-ben-corps'
- updated unit test

Co-authored-by: Severin Beauvais <[email protected]>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-filings-ui",
-  "version": "7.4.7",
+  "version": "7.4.8",
   "private": true,
   "appName": "Filings UI",
   "sbcName": "SBC Common Components",

src/stores/businessStore.ts

@@ -280,18 +280,13 @@ export const useBusinessStore = defineStore('business', {
     },
 
     /**
-     * Is True for non-BEN corps if FF is disabled.
-     * Is False for BENs and other entity types.
+     * Is True for any business in the FF list, else False.
      * Used to apply special pre-go-live functionality.
      */
     isDisableNonBenCorps (): boolean {
-      if (
-        this.isEntityBcCompany || this.isEntityBcCcc || this.isEntityBcUlcCompany ||
-        this.isEntityContinueIn || this.isEntityCccContinueIn || this.isEntityUlcContinueIn
-      ) {
-        return !GetFeatureFlag('enable-non-ben-corps')
-      }
-      return false
+      // initially, this was True for all non-BEN corps (when FF was off)
+      // now, this is True for the specified businesses only
+      return !!GetFeatureFlag('businesses-to-manage-in-colin')?.includes(this.getIdentifier)
     },
 
     //

src/utils/feature-flags.ts

@@ -9,9 +9,9 @@ declare const window: any
  */
 const defaultFlagSet: LDFlagSet = {
   'banner-text': '', // by default, there is no banner text
+  'businesses-to-manage-in-colin': [],
   'enable-digital-credentials': false,
   'enable-legal-name-fix': false,
-  'enable-non-ben-corps': false,
   'sentry-enable': false, // by default, no sentry logs
   'show-alert-phone-numbers-firm': false,
   'supported-agm-extension-entities': [],

tests/unit/CorporateOnline.spec.ts

@@ -17,9 +17,11 @@ describe('Corporate Online alert', () => {
   beforeAll(() => {
     businessStore.$state.businessInfo.goodStanding = true
     businessStore.$state.businessInfo.legalType = CorpTypeCd.BC_COMPANY
+    businessStore.$state.businessInfo.identifier = 'BC1234567'
+
     vi.spyOn(utils, 'GetFeatureFlag').mockImplementation(flag => {
-      if (flag === 'enable-non-ben-corps') return false
-      return null
+      if (flag === 'businesses-to-manage-in-colin') return ['BC1234567']
+      return []
     })
   })