Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed alert banner styles #702

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

severinbeauvais
Copy link
Collaborator

Issue #: None

Description of changes:

  • app version = 7.4.4
  • removed white border below app alert
  • removed "!" due to alert type
  • fixed colors

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

- removed white border below app alert
- removed "!" due to alert type
- fixed colors
@severinbeauvais
Copy link
Collaborator Author

Before:
image

After:
image


.color-white {
color: white;
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This now matches the style/accessibility of the alert banner in Auth Web, ie:

image

@severinbeauvais severinbeauvais merged commit 58e296b into bcgov:main Nov 13, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants