Breadcrumb devsite #167
Merged
Breadcrumb devsite #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajandeep98
requested review from
thorwolpert,
deetz99,
kris-daxiom,
kialj876 and
pwei1018
as code owners
|
/gcbrun |
|
Temporary Url for review: https://developer-connect-dev--pr-167-liaofvqk.web.app |
pwei1018
approved these changes
Dec 3, 2024
Rajandeep98
force-pushed
the
Breadcrumb_Devsite
branch
from
717fe59 to
5893700
Compare
Rajandeep98
force-pushed
the
Breadcrumb_Devsite
branch
from
5893700 to
0a0ae65
Compare
|
/gcbrun |
|
Temporary Url for review: https://developer-connect-dev--pr-167-1rexgsiy.web.app |
|
/gcbrun |
|
Temporary Url for review: https://developer-connect-dev--pr-167-1rexgsiy.web.app |
|
/gcbrun |
|
Temporary Url for review: https://developer-connect-dev--pr-167-1rexgsiy.web.app |
|
/gcbrun |
|
Temporary Url for review: https://developer-connect-dev--pr-167-1rexgsiy.web.app |
sameer0422
approved these changes
Dec 10, 2024
| const bc = [ | ||
| { label: t('sbcBreadcrumb.default'), to: 'https://bcregistry.gov.bc.ca/' } | ||
| ] | ||
| bc.push({ label: t('sbcBreadcrumb.sbcHome'), to: '/' }) |
There was a problem hiding this comment.
Why do you need this line?
You can do like this:
const bc = [
{ label: t('sbcBreadcrumb.default'), to: 'https://bcregistry.gov.bc.ca/' },
{ label: t('sbcBreadcrumb.sbcHome'), to: '/' }
]
| } | ||
| }) | ||
|
|
||
| function resolveBackHref () { |
There was a problem hiding this comment.
I think it's better to use computed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ref. code: nuxt/layers/core/app/components/Connect )