Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cards & Footer #170

Merged
merged 1 commit into from
Dec 9, 2024
Merged

cards & Footer #170

merged 1 commit into from
Dec 9, 2024

Conversation

Rajandeep98
Copy link
Collaborator

  • added cards instead of buttons
  • updated footer links including tests

sameer0422
sameer0422 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@sameer0422 sameer0422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Rajandeep98
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://developer-connect-dev--pr-170-4wakrwb0.web.app

@Rajandeep98 Rajandeep98 merged commit 4c4d638 into bcgov:main Dec 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameer0422 sameer0422 sameer0422 approved these changes

@thorwolpert thorwolpert Awaiting requested review from thorwolpert thorwolpert is a code owner

@deetz99 deetz99 Awaiting requested review from deetz99 deetz99 is a code owner

@kris-daxiom kris-daxiom Awaiting requested review from kris-daxiom kris-daxiom is a code owner

@kialj876 kialj876 Awaiting requested review from kialj876 kialj876 is a code owner

@pwei1018 pwei1018 Awaiting requested review from pwei1018 pwei1018 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rajandeep98 @bcregistry-sre @sameer0422