24987 24989 - Update to enable NoW for temporary businesses #3155
Conversation
| @@ -479,7 +479,8 @@ def put_basic_checks(identifier, filing, client_request, business) -> Tuple[dict | |||
| if not filing_type: | |||
| return ({'message': 'filing/header/name is a required property'}, HTTPStatus.BAD_REQUEST) | |||
|
|
|||
| if filing_type not in CoreFiling.NEW_BUSINESS_FILING_TYPES and business is None: | |||
| if filing_type not in CoreFiling.NEW_BUSINESS_FILING_TYPES + [CoreFiling.FilingTypes.NOTICEOFWITHDRAWAL] \ | |||
There was a problem hiding this comment.
allow filing NoW without an existing business
| @@ -668,6 +674,9 @@ def get_filing_types(business: Business, filing_json: dict): # pylint: disable= | |||
|
|
|||
| if filing_type in CoreFiling.NEW_BUSINESS_FILING_TYPES: | |||
| legal_type = filing_json['filing'][filing_type]['nameRequest']['legalType'] | |||
| elif business.identifier.startswith('T') and \ | |||
| filing_type == CoreFiling.FilingTypes.NOTICEOFWITHDRAWAL: | |||
| legal_type = filing_json['filing'].get('business', None).get('legalType') | |||
There was a problem hiding this comment.
for temporary business notice of withdraw, get legalType from filing json
| filing.filing_type == Filing.FILINGS['noticeOfWithdrawal']['name']: | ||
| mailing_address, corp_type, legal_name = \ | ||
| ListFilingResource._get_address_from_withdrawn_new_business_filing(business, filing) | ||
| business.legal_name = legal_name |
There was a problem hiding this comment.
for temporary business notice of withdraw, get mailng_address, corp_type, legal_name from the withdrawn new business filing (e.g. IA, Continuation In, Amalgamation)
| @@ -321,7 +321,8 @@ def get_allowable_filings_dict(): | |||
| 'legalTypes': ['BC', 'BEN', 'CC', 'ULC', 'C', 'CBEN', 'CUL', 'CCC'], | |||
| 'blockerChecks': { | |||
| 'business': [BusinessBlocker.FILING_WITHDRAWAL] | |||
| } | |||
| }, | |||
| 'businessRequirement': BusinessRequirement.NO_RESTRICTION | |||
There was a problem hiding this comment.
Allow NoW filing no matter there is an existing business or not for staff
|
eason-pan-bc
requested review from
vysakh-menon-aot,
meawong,
ArwenQin and
severinbeauvais
| legal_type = business.legal_type | ||
| # for temporary business notice of withdraw, get legalType from filing json | ||
| elif filing_type == CoreFiling.FilingTypes.NOTICEOFWITHDRAWAL.value: | ||
| legal_type = filing_json['filing'].get('business', None).get('legalType') |
There was a problem hiding this comment.
Does this work if the NoW is for a regular business? (eg, withdrawing a FE alteration)
There was a problem hiding this comment.
Are there already tests for NoW with a regular business filing (eg, COA, Alteration, others?)?
Issue #: /bcgov/entity#24987
Issue #: /bcgov/entity#24989
Description of changes:
/api/v2/businesses/:identifier/filingsto enable NoW filing for T businessesLocal Verifications
1 - Update error code for not found withdrawn filing from 400 to 404
Before:
After:
2 - Enable NoW filing for T businesses
Before:
After:
3 - Not allow file other filings for T businesses
e.g. CoD
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).