Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Examination UI: need to update NR request types#24255 #1549

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

stevenc987
Copy link
Collaborator

@stevenc987 stevenc987 commented Nov 15, 2024

*Issue #: 24255
bcgov/entity#24255

Description of changes:

  1. Added missing type: BECC - Benefit Company -> Community Contribution Company
  2. ULCB duplicated and removed one of them (Unlimited Liability Company to BC Limited Conversion)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).

app/enums/codes.ts Show resolved Hide resolved
@severinbeauvais
Copy link
Collaborator

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namex-dev--pr-1549-cs02n1t0.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but would be nice to test before merging.

@severinbeauvais severinbeauvais merged commit f29d5c3 into bcgov:main Nov 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants