23527 Changed a button label + updated README #778
Conversation
- added pnpm install instruction to README - update app title in README - updated browserslist (caniuse) - changed "Continue In Now" to "Begin Continuation"
severinbeauvais
requested review from
eve-git,
shaangill025,
stevenc987,
ozamani9gh,
rarmitag,
flutistar and
EPortman
as code owners
ScreenshotsFrom first page (numbered)
From NR page (named)
|
| @@ -1,9 +1,10 @@ | |||
| # Name Request Online Frontend | |||
| # Name Request UI | |||
There was a problem hiding this comment.
This is what we always call it (and sometimes "Namerequest UI" as per the repo name).
We should not refer to "NRO" in the name.
There was a problem hiding this comment.
@rarmitag Am I missing something here -- did the name actually change?
|
|
||
| [](https://github.com/bcgov/repomountie/blob/master/doc/lifecycle-badges.md) | ||
|
|
||
| ## Project setup | ||
| ``` | ||
| npm install -g pnpm | ||
| pnpm install |
There was a problem hiding this comment.
I had to look up how to use pnpm, so here I'm saving the next person a couple of minutes :)
There was a problem hiding this comment.
Same thing happened to me a while ago. Good idea.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "name-request", | |||
| "version": "5.5.8", | |||
| "version": "5.5.9", | |||
There was a problem hiding this comment.
I updated the version number.
I assume "pnpm" updated the other package versions.
Note that I did run the command npx update-browserslist-db@latest as recommended,
There was a problem hiding this comment.
The package updates below should make no difference because (theoretically) the ^ instructed npm/node to use the latest minor/patch versions of the package, which is what the changes below do explicitly.
In other words, even though we asked for "compat-data v7.21.5", we were already using v7.24.4 due to the ^ symbol.
|
@rarmitag If this looks OK to you, please merge it. Thanks! |
Issue #: bcgov/entity#23527
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).