Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

25066 - Fix BEN Conversion for Unauthorized Users #791

Conversation

meawong
Copy link
Collaborator

@meawong meawong commented Jan 3, 2025

Issue #: /bcgov/entity#25066

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@meawong
Copy link
Collaborator Author

meawong commented Jan 3, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Jan 3, 2025

Temporary Url for review: https://namerequest-dev--pr-791-k9i4w5ns.web.app

LEAR ex: BC0884813
COLIN ex: BC0808036

@meawong meawong self-assigned this Jan 3, 2025
app/package.json Outdated Show resolved Hide resolved
meawong and others added 12 commits January 3, 2025 09:28
* 24205 - updates for name change and alteration ff

* 24205 - remove feature flags

* 24205 - remove feature flags

* 24205 - update version

* 24205 - remove unsused import

* 24205 - remove consitional chaining

* 24205 - update funstions

* 24205

* 24205

* 24205- update mounted() with async
…cgov#786)

* Added check for limited restoration

* Added condition to use exact look up (BusinessFetch) component for restoration NRs
…v#787)

* fix: allow historical businesses to request restoration NR
@meawong meawong force-pushed the 25066-Fix-LEAR-BEN-conversion-for-numbered-companies branch from c9ce5d2 to 3edf707 Compare January 3, 2025 17:30
@meawong
Copy link
Collaborator Author

meawong commented Jan 3, 2025

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Jan 3, 2025
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-791-k9i4w5ns.web.app

@meawong
Copy link
Collaborator Author

meawong commented Jan 3, 2025

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-791-k9i4w5ns.web.app

@meawong meawong merged commit b394b94 into bcgov:main Jan 3, 2025
9 of 10 checks passed
@severinbeauvais
Copy link
Collaborator

Last thing -- make sure your ticket is linked to an appropriate Names Team release (since they release this UI to Test and then Prod). If you can't identify an appropriate release, please check with Names Team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants