Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: secret-keep #714

Merged
merged 28 commits into from
Oct 21, 2024
Merged

fix: secret-keep #714

merged 28 commits into from
Oct 21, 2024

Conversation

jon-funk
Copy link
Collaborator

@jon-funk jon-funk commented Oct 17, 2024 •
edited by github-actions bot
Loading

Description

Fixes helm install case for secrets with keep policy

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Deleted secret in dev namespace and they were recreated
  • modified secrets both before deletion and after deletion with additional rollouts in between to check secret changes maintained

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

gregorylavery and others added 20 commits October 3, 2024 15:26
@gregorylavery @barrfalk
@dk-bcps @Scarlett-Truong @marqueone-ps @jeznorth @renovate @afwilcox
fix: Ce 478 (#685)
5e72328 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: dmitri-korin-bcps <[email protected]>
Co-authored-by: Scarlett <[email protected]>
Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike Sears <[email protected]>
Co-authored-by: jeznorth <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
Co-authored-by: Scarlett <[email protected]>
@nayr974
chore(CE-1118): CE-1118 Add Ryan as officer for test and prod (#689)
da3a597
@jon-funk
chore(CE-1118): add Jon as officer to test and prod data (#688)
da5087f
@mikevespi @barrfalk
chore: CE 1119 add Mike to users (#690)
94f9304 
Co-authored-by: barrfalk <[email protected]>
@afwilcox
feat: CE-750 Display Current Date in Filter when only one date select…
043c1e7 
…ed (#697)
@nayr974 @afwilcox
chore(CE-535): Refactor ValidationInput and ValidationSelect to use C…
343bf71 
…ompInput and CompSelect (#696)

Co-authored-by: afwilcox <[email protected]>
@afwilcox
fix: CE-1050 Makes it so cypress tests work on empty case management …
91c1b3b 
…database (#695)
@mishraomp @afwilcox
chore(ci): Dockerfile updates (#693)
e2b7101 
Signed-off-by: OMPRAKASH MISHRA <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@nayr974
fix: Config.js error while developing locally (#699)
b4f59cd
@afwilcox
fix: Clear CDOGS templates with every run (#700)
70f8b02
@gregorylavery @afwilcox
fix: Ce 1127 (#694)
b8aae06 
Co-authored-by: afwilcox <[email protected]>
@renovate @afwilcox
chore(deps): update dependency @types/jest to v29.5.13 (#704)
fde5a56 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: afwilcox <[email protected]>
@dk-bcps
feat: CE-550- modal-improvements-V2 (#703)
a788f68
@afwilcox
feat: Method Complaint Received Cypress Tests (#701)
46d6c1d
@nayr974
fix: CE 1124 (#705)
d86e33e
@dk-bcps @afwilcox
fix: CE-1143-apply-scroll-bar-to-assign-modal (#710)
24a3c76 
Co-authored-by: afwilcox <[email protected]>
@jon-funk @barrfalk @afwilcox
fix: CE-917 enable autoscaling for test (#702)
02d58eb 
Co-authored-by: Barrett Falk <[email protected]>
Co-authored-by: afwilcox <[email protected]>
@jon-funk @afwilcox
fix: CE-1078 persist secret content changes between rollouts (#698)
9df80c5 
Co-authored-by: afwilcox <[email protected]>
@mikevespi @afwilcox
feat: CE-1045 add action taken filter for ceeb (#708)
20d34a3 
Co-authored-by: afwilcox <[email protected]>
@jon-funk
test commit
270f1f6
@jon-funk jon-funk added bug Something isn't working invalid This doesn't seem right labels Oct 17, 2024
@jon-funk jon-funk changed the title test commit fix/secret-keep Oct 17, 2024
@jon-funk jon-funk changed the title fix/secret-keep fix: secret-keep Oct 18, 2024
@jon-funk jon-funk removed the invalid This doesn't seem right label Oct 18, 2024
@jon-funk jon-funk added the pipeline change Change that updates the pipeline label Oct 18, 2024
@afwilcox afwilcox changed the base branch from release/lions-mane-jellyfish to release/noble-sea-lemon October 21, 2024 17:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@afwilcox afwilcox merged commit ab9f0b8 into release/noble-sea-lemon Oct 21, 2024
15 checks passed
@afwilcox afwilcox deleted the fix/secret-keep branch October 21, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwilcox afwilcox afwilcox approved these changes

Assignees
No one assigned
Labels
bug Something isn't working pipeline change Change that updates the pipeline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jon-funk @afwilcox @gregorylavery @nayr974 @mikevespi @mishraomp @dk-bcps