Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add link to home page from error pages #719

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

afwilcox
Copy link
Collaborator

@afwilcox afwilcox commented Oct 22, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # CE-1080

Adds a link to the home page of the application on the 3 error pages (Not Found, Not Authorized, Generic Error)

Also includes a standization of wording and tidy of the CSS to make the messaging display consistently on all screen sizes.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Error: Go into complaint details and change the number of the complaint (e.g. /complaint/HWCR/24-8675309)
  • Not Found: Replace /complaint in the URL with something that doesn’t exist. (e.g. /bears)
  • Not Authorized: Go to the page directly (/not-authorized)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Contributor

@gregorylavery gregorylavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from my super-pedantic wording suggestion this all looks good. Approved by me.

<div className="message">
<BsFileEarmarkX />
<div className="message-details">
<h1 className="comp-padding-top-25">The page or content you are looking for is not found.</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick - this is grammatically incorrect. I personally would say "The page or content you are looking for has not been found."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to "could not be found" as per conversation with Neil.

Copy link

@afwilcox afwilcox merged commit 0264469 into release/noble-sea-lemon Oct 23, 2024
15 checks passed
@afwilcox afwilcox deleted the CE-1080-add-link-to-error-pages branch October 23, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants