Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add COORS Number to Complaints #723

Merged

Conversation

afwilcox
Copy link
Collaborator

@afwilcox afwilcox commented Oct 24, 2024

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

#CE-230

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Can Create/Edit/Delete Number on HWCR
  • Can Create/Edit/Delete Number on HWCR
  • Validation Rules Implemented
  • Can Search on Number
  • Can See Number in Export
  • Section doesn't appear for CEEB
  • Section doesn't appear on GIR

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

afwilcox and others added 20 commits October 22, 2024 12:06
fix: Clear validation state on cancel/save
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

@gregorylavery gregorylavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done and nothing much to add. Marking as APPROVE.

@afwilcox afwilcox merged commit bb20e33 into release/noble-sea-lemon Oct 28, 2024
16 of 17 checks passed
@afwilcox afwilcox deleted the CE-230-add-reference-number-to-complaint branch October 28, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants