Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CE-1108 #724

Merged
merged 5 commits into from
Oct 25, 2024
Merged

fix: CE-1108 #724

merged 5 commits into from
Oct 25, 2024

Conversation

gregorylavery
Copy link
Contributor

@gregorylavery gregorylavery commented Oct 25, 2024

Description

Modifies how the filenames are generated for exports when the users are from different agencies.

Fixes # CE-1108

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • As a COS user export a HWCR and confirm that the filename for the PDF generated is in the correct format.

  • As a COS user export a ERS and confirm that the filename for the PDF generated is in the correct format.

  • As a COS user export a GIR and confirm that the filename for the PDF generated is in the correct format.

  • As a CEEB user export a ERS and confirm that the filename for the PDF generated is in the correct format.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress tests will need updates with the new names.

Copy link

@afwilcox afwilcox merged commit 5b7147c into release/noble-sea-lemon Oct 25, 2024
15 checks passed
@afwilcox afwilcox deleted the CE-1108 branch October 25, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants