chore: Fix mapSearch agency check for CEEB users #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complaints service's mapSearch function uses the local function _getAgencyByUser to determine a users agency. This function identifies a users agency through the office they are assigned to. CEEB users have no office assigned, thus _getAgencyByUser fails. To get around this, mapSearch now uses the hasCEEBRole variable already included to determine if _getAgencyByUser should be called, or "EPO" should be assigned (as is the case for CEEB users). Current implementation of tests do not address the problem, and there was an existing false positive in the tests for the complaints service. This will be addressed separately.
afwilcox
requested changes
Nov 5, 2024
|
afwilcox
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complaints service's
mapSearchfunction uses the local function_getAgencyByUserto determine a users agency. This function identifies a users agency through the office they are assigned to. CEEB users have no office assigned, thus_getAgencyByUserfails. To get around this,mapSearchnow uses thehasCEEBRolevariable already included to determine if_getAgencyByUsershould be called, or "EPO" should be assigned (as is the case for CEEB users). Current implementation of tests do not address the problem, and there was an existing false positive in the tests for the complaints service. This will be addressed separately.Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: