Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CE-501 Admin page #852

Open
wants to merge 23 commits into
base: release/0.6.12
Choose a base branch
from
Open

feat: CE-501 Admin page #852

wants to merge 23 commits into from

Conversation

Scarlett-Truong
Copy link
Collaborator

@Scarlett-Truong Scarlett-Truong commented Jan 6, 2025

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Further comments


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@Scarlett-Truong Scarlett-Truong changed the title CE-501 Admin page feat: CE-501 Admin page Jan 6, 2025
Copy link
Collaborator

@afwilcox afwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! A couple of functional items:

Adding Users:

  • CSS App link should open in a new tab
  • After you have searched for an email I think think the cancel button should go back to the 'Email Search' screen to allow the user to enter a different email address
  • For now I think Parks users should only have the option of "Read Only" role

Editing Users:

  • Email address does not show up
  • Editing doesn't seem to work

@Scarlett-Truong
Copy link
Collaborator Author

Overall looks good! A couple of functional items:

Adding Users:

  • CSS App link should open in a new tab
  • After you have searched for an email I think think the cancel button should go back to the 'Email Search' screen to allow the user to enter a different email address
  • For now I think Parks users should only have the option of "Read Only" role

Editing Users:

  • Email address does not show up
  • Editing doesn't seem to work

@afwilcox Thanks for reviewing it.

Adding Users:

CSS App link should open in a new tab -> oh ya, I forgot -.-
After you have searched for an email I think think the cancel button should go back to the 'Email Search' screen to allow the user to enter a different email address
-> yeah, I'm not sure about this, cuz there's no back button in the design to go back to the main landing page one (the one with Select user"). So once they click "Add new user", and decide not to, maybe they just have to click on the nav bar "User administration" again?
For now I think Parks users should only have the option of "Read Only" role --> I don't implement anything with Parks tho, maybe should hide this option

Editing Users:

Email address does not show up --> cuz we don't store email in our db, so I can't populate it. Maybe should we hide it?
Editing doesn't seem to work -> can you specify, in which case it is not working? If you want to see the changes in Complaint tab, you need to refresh the page :(

@Scarlett-Truong
Copy link
Collaborator Author

Sonarcloud:

  • Duplicated issue is complaining about 2 same types I have for FE and BE, probably skipped it for now, will be moved to the share-type repo later
  • Refactor this function to reduce its Cognitive Complexity: already reduced it. Looking into more if there are no bugs/ other requirements or will do it in another ticket.

Copy link

sonarqubecloud bot commented Jan 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants