-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: CE-501 Admin page #852
base: release/0.6.12
Are you sure you want to change the base?
Conversation
Co-authored-by: jon-funk <[email protected]> Co-authored-by: Derek Roberts <[email protected]>
Co-authored-by: afwilcox <[email protected]>
Co-authored-by: afwilcox <[email protected]>
Co-authored-by: afwilcox <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! A couple of functional items:
Adding Users:
- CSS App link should open in a new tab
- After you have searched for an email I think think the cancel button should go back to the 'Email Search' screen to allow the user to enter a different email address
- For now I think Parks users should only have the option of "Read Only" role
Editing Users:
- Email address does not show up
- Editing doesn't seem to work
@afwilcox Thanks for reviewing it. Adding Users: CSS App link should open in a new tab -> oh ya, I forgot -.- Editing Users: Email address does not show up --> cuz we don't store email in our db, so I can't populate it. Maybe should we hide it? |
Sonarcloud:
|
Quality Gate failedFailed conditions |
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: