Initialize a metric web #28
Conversation
|
/gcbrun |
|
Temporary Url for review: https://release-notes-dev--pr-28-p8uyp7og.web.app |
|
/gcbrun |
|
Temporary Url for review: https://release-notes-dev--pr-28-p8uyp7og.web.app |
There was a problem hiding this comment.
Some general comments
- How do I access apps/application-status/pages/index.vue in gcbrun deployment - looks like it is still work in progress... The purpose of PR states "Is this Initialize a website for displaying metrics for each team", I assume that index.vue is the crux of your PR, but there are also other changes like fonts. pipeline changes, etc. that distract from the main purpose of the PR
- Next/Prev buttons seems to work only for a single cycle (i.e. repeatedly clicking prev/next stops working) based on gcbrun deployment
- Also, think would be better to rename "Done Releases" to "Completed Releases" here
| @@ -42,6 +41,9 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pnpm install | |||
There was a problem hiding this comment.
do you need to run pnpm install twice: once here and then late in build-check?
There was a problem hiding this comment.
This one I replicated what Patrick set up in release-notes-ci.yaml, I thought in each checking section, we needed to run pnpm install
| @@ -66,9 +68,12 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| pnpm install | |||
There was a problem hiding this comment.
same as above: reason for double pnpm install?
| </div> | ||
| <br> | ||
| <div> | ||
| <b>Relationships</b> = authentication, payments and other features. |
There was a problem hiding this comment.
Probably need to capitalize the first word -> Authentication
| <br> | ||
| <div> | ||
| <h1 class="contact-title"> | ||
| Legend: |
There was a problem hiding this comment.
Are you missing "Names" team in the legend?
There was a problem hiding this comment.
My supervisor Trish sent these terms for me to include these terms for more clarification on audience's side. I believe the "Name" team carries their meaning on their own already therefore Trish did not include it in. I will double check it with her.
| </div> | ||
| <br> | ||
| <div> | ||
| <b class="text-2xl">NAME TEAM REPO</b> |
There was a problem hiding this comment.
A bit confused about this file, how do I view it from the main page using the temp gcbrun deployment? Are NAME TEAM REPO and ENTITIES REPO just placeholders?
There was a problem hiding this comment.
This is the current display of the page,
It's a MVP product and current stage is just to display the correct information on screen before taking UI into consideration so I haven't styled it yet
| @@ -0,0 +1,8 @@ | |||
| enum Zenhub { | |||
| ENTITIES = '5bf2f2164b5806bc2bf60531', | |||
There was a problem hiding this comment.
what are these keys? should they be in a secret?
There was a problem hiding this comment.
I thought the Zenhub's boardID is a public ID because it is exposed in the URL link https://app.zenhub.com/workspaces/entity-5bf2f2164b5806bc2bf60531/ so it can be enum like that. I also tried putting it in env file, but when pushing it, it would fail some CI checkings
Summary
Initialize a website for displaying metrics for each team