Fix beancount3 duplicate logic #1937
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With beancount3 the __duplicate__ field can now contain the original entry instead of "True", mapping this to the old "True" value for the rest of the import logic to work
tarioch
force-pushed
the
bugfix/import_duplicates
branch
from
46ea605 to
e5d45b7
Compare
|
@yagebu lint doesn't pass but I'm not getting what I should adjust. I'm more or less following the code here https://github.com/beancount/beangulp/blob/f8d2bc5da40e74461772dcb8e8394fa3c1b2a65d/beangulp/extract.py#L221 |
|
In the types in this repo, the metadata is typed as immutable, so you're not allowed to modify that (without creating a new entry and replacing the existing one). I don't think there's any reason to mutate it, see #1938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With beancount3 the duplicate field can now contain the original entry instead of "True", mapping this to the old "True" value for the rest of the import logic to work