Use new Surface API #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kangz
reviewed
May 13, 2024
| [](WGPURequestDeviceStatus status, WGPUDevice cDevice, | ||
| const char* message, void* userdata) { | ||
| wgpu::Device device = wgpu::Device::Acquire(cDevice); | ||
| device.SetUncapturedErrorCallback( |
There was a problem hiding this comment.
Note that this will be part of the descriptor soon.
There was a problem hiding this comment.
(It is already there in Dawn, but Emscripten doesn't implement it.)
Kangz
approved these changes
May 13, 2024
beaufortfrancois
force-pushed
the
remove-swapchain
branch
3 times, most recently
from
64a5abc to
6a83afa
Compare
beaufortfrancois
force-pushed
the
remove-swapchain
branch
from
6a83afa to
1a5995e
Compare
kainino0x
reviewed
May 15, 2024
kainino0x
reviewed
May 15, 2024
|
@kainino0x @Kangz I've updated this PR. Note that I'm now reusing |
beaufortfrancois
force-pushed
the
remove-swapchain
branch
from
369cf43 to
9370eb7
Compare
Kangz
approved these changes
May 21, 2024
kainino0x
approved these changes
May 22, 2024
|
@kainino0x I've addressed your latest feedback. I'll merge when emscripten changes land. Thank you! |
kainino0x
approved these changes
May 23, 2024
|
I'll merge when Chrome 126 hits stable. Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Emscripten, it requires emscripten-core/emscripten#21939