Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package: fix release workflow, exclude plugin tests, include all files from MANIFEST.in #5536

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

snejus
Copy link
Member

@snejus snejus commented Dec 5, 2024

Fixes #5526
Fixes #5531
Fixes #5539

Package contents

See #5526 where a package maintainer fails running plugin tests. I found that before
introduction of Poetry beets never bundled plugin tests, therefore I now excluded them.

I also remembered that previously MANIFEST.in file was used to specify which files get
included in the package, so I mirrored the same configuration. This includes zsh
completion in extra/_beet which fixes #5531.

I removed MANIFEST.in file since it has no use anymore.

Release workflow

The last release workflow run failed to pick up the commit with the version updates and
tagged an outdated commit (#5539). I simplified the workflow to create the tag at the same
time the version upgrade is committed.

@snejus snejus self-assigned this Dec 5, 2024
@snejus snejus requested review from JOJ0 and bal-e December 5, 2024 11:27
@snejus snejus changed the title Package: exclude plugin tests, include all files from MANIFEST.in Package: fix release workflow, exclude plugin tests, include all files from MANIFEST.in Dec 8, 2024
Copy link
Contributor

@Serene-Arc Serene-Arc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea moving the stage where we make the release tag! I'm good with these changes, merge when you please.

@snejus snejus merged commit 3cc129b into master Dec 10, 2024
15 checks passed
@snejus snejus deleted the fix-package-v2 branch December 10, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants