Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no build before npm publish #199

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

pplancq
Copy link
Contributor

@pplancq pplancq commented Mar 25, 2024

Hello @bencompton ,

Sorry for the direct mention, but there's a big problem with the github publish action. The build step is missing, which means the dist folder isn't published to the npm registry.
This makes the library unusable.

image

I suggest this quick fix to quickly fix and republish a patched version.

@pplancq pplancq force-pushed the bugfix/publishAction branch 2 times, most recently from ace9b36 to b1d8f8c Compare March 25, 2024 11:06
@pplancq pplancq force-pushed the bugfix/publishAction branch from b1d8f8c to 91e4a94 Compare March 25, 2024 12:27
@bencompton bencompton merged commit 77617bd into bencompton:master Mar 25, 2024
2 checks passed
@bencompton
Copy link
Owner

Thanks a bunch for catching this! I tested 4.0.1 in another project, but now that I double check, it was still using the previous version. 🤦

@pplancq
Copy link
Contributor Author

pplancq commented Mar 25, 2024

No problem, to err is human as they say.
On the other hand, I notice that you didn't release 4.0.2 on the master.
image

@pplancq pplancq deleted the bugfix/publishAction branch March 25, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants