Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic done callback compatibility in steps #228

Merged
merged 3 commits into from
May 15, 2024

Conversation

ychavoya
Copy link
Contributor

Closes #16

Description of changes

  • Added compatibility for done callback usage in functions for steps
  • Added tests for the done callback usage
  • Fixed a unit test that was not properly configured (conflicted with the new changes)
  • Updated the type of the stepArgument property of ParsedStep to better reflect the possible values.
  • Updated documentation with the done callback information

Any issue please let me know, thanks

@bencompton bencompton merged commit 793a056 into bencompton:main May 15, 2024
3 checks passed
Copy link

🎉 This PR is included in version 4.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bencompton
Copy link
Owner

This feature has been missing for quite some time, so thanks for contributing this!

@ychavoya ychavoya deleted the done-callback branch May 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support done callback in addition to promises
2 participants