Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tds #279

Draft
wants to merge 2 commits into
base: releases/v18
Choose a base branch
from
Draft

feat: tds #279

wants to merge 2 commits into from

Conversation

v-rocheleau
Copy link
Contributor

No description provided.

@v-rocheleau v-rocheleau changed the base branch from main to releases/v17.1 October 21, 2024 21:20
@@ -216,6 +216,7 @@ def init_dirs():
"reference-db": "BENTO_REFERENCE_DB_VOL_DIR",
"wes": "BENTOV2_WES_VOL_DIR",
"wes-tmp": "BENTOV2_WES_VOL_TMP_DIR",
"tds-db": "BENTO_TDS_DB_VOL_DIR",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put in alpha order

@@ -299,6 +300,8 @@ def init_docker(client: docker.DockerClient):
("BENTO_SERVICE_REGISTRY_NETWORK", dict(driver="bridge")),
("BENTO_WEB_NETWORK", dict(driver="bridge")),
("BENTO_WES_NETWORK", dict(driver="bridge")),
("BENTO_TDS_NETWORK", dict(driver="bridge")),
("BENTO_TDS_DB_NETWORK", dict(driver="bridge", internal=True)), # Does not need to access the web
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put in alpha order (above W)

@@ -140,6 +140,8 @@ The following is a list of all host port allocations for Bento services in devel
| Reference | 9510 | 9501 |
| Reference DB | 9512 | `N/A` |
| Service Registry | 5010 | Unimplemented |
| TDS | 9520 | 9520 |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the debugger port can't match the service port

BENTO_TDS_NETWORK=${BENTOV2_PREFIX}-tds-net
BENTO_TDS_INTERNAL_PORT=${BENTO_STD_SERVICE_INTERNAL_PORT}
BENTO_TDS_EXTERNAL_PORT=9520
BENTO_TDS_DEBUGGER_INTERNAL_PORT=9511
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this unique?

@davidlougheed davidlougheed changed the base branch from releases/v17.1 to releases/v18 December 4, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants