-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tds #279
base: releases/v18
Are you sure you want to change the base?
feat: tds #279
Conversation
@@ -216,6 +216,7 @@ def init_dirs(): | |||
"reference-db": "BENTO_REFERENCE_DB_VOL_DIR", | |||
"wes": "BENTOV2_WES_VOL_DIR", | |||
"wes-tmp": "BENTOV2_WES_VOL_TMP_DIR", | |||
"tds-db": "BENTO_TDS_DB_VOL_DIR", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put in alpha order
@@ -299,6 +300,8 @@ def init_docker(client: docker.DockerClient): | |||
("BENTO_SERVICE_REGISTRY_NETWORK", dict(driver="bridge")), | |||
("BENTO_WEB_NETWORK", dict(driver="bridge")), | |||
("BENTO_WES_NETWORK", dict(driver="bridge")), | |||
("BENTO_TDS_NETWORK", dict(driver="bridge")), | |||
("BENTO_TDS_DB_NETWORK", dict(driver="bridge", internal=True)), # Does not need to access the web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put in alpha order (above W)
@@ -140,6 +140,8 @@ The following is a list of all host port allocations for Bento services in devel | |||
| Reference | 9510 | 9501 | | |||
| Reference DB | 9512 | `N/A` | | |||
| Service Registry | 5010 | Unimplemented | | |||
| TDS | 9520 | 9520 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the debugger port can't match the service port
BENTO_TDS_NETWORK=${BENTOV2_PREFIX}-tds-net | ||
BENTO_TDS_INTERNAL_PORT=${BENTO_STD_SERVICE_INTERNAL_PORT} | ||
BENTO_TDS_EXTERNAL_PORT=9520 | ||
BENTO_TDS_DEBUGGER_INTERNAL_PORT=9511 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this unique?
No description provided.