WIP: Ring 0.17 #508
Merged
WIP: Ring 0.17 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion root_cert_store rustls::ServerCertVerifierBuilder::build() returns a `CertVerifierBuilderError` if no trust anchors have been provided.
In keeping with webpki-roots - the TrustAnchors are managed without the Der Tag::Sequence header This in turn requires that: - the header is removed from x509 fields before saving in the pddb, and - the der Tag::Sequence is added to ota.subject before it can be decoded () see ota.subject()
we'll port it forward if we end up needing to get that deep into the crate.
this will allow the gh actions check to succeed, hopefully?
@nworbnhoj, i saw you had explicitly done a formatting pass. However, I think maybe the +nightly flag was missing, it looks like the formatting ignored our custom rule set, which requires nightly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP branch for
ring 0.17forward-port. It's mostly a placeholder for when we actually want to move ahead with pulling the rest of the stuff. See #507 for a tracking issue on this.