Skip to content

Commit

Permalink
fix: patch ci
Browse files Browse the repository at this point in the history
  • Loading branch information
@sakulstra
sakulstra committed Nov 27, 2024
1 parent b97d9bc commit e4a094d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/comment.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@ on:
- completed

jobs:
comment-pr:
if: github.ref != format('refs/heads/{0}', github.event.repository.default_branch)
comment:
uses: bgd-labs/github-workflows/.github/workflows/comment.yml@main
secrets:
READ_ONLY_PAT: ${{ secrets.READ_ONLY_PAT }}
comment-commit:
if: github.ref == format('refs/heads/{0}', github.event.repository.default_branch)
uses: bgd-labs/github-workflows/.github/workflows/comment.yml@main
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ jobs:
- name: Run Gas report
uses: bgd-labs/github-workflows/.github/actions/foundry-gas-report@main

- name: Store artifact
uses: bgd-labs/github-workflows/.github/actions/comment-artifact@main

- name: Run Lcov report
uses: bgd-labs/github-workflows/.github/actions/foundry-lcov-report@main

- name: Store artifact
uses: bgd-labs/github-workflows/.github/actions/comment-artifact@main

# we let failing tests pass so we can log them in the comment, still we want the ci to fail
- name: Post test
if: ${{ steps.test.outputs.testStatus != 0 || steps.zktest.outputs.testStatus != 0 }}
Expand Down

4 comments on commit e4a094d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛽ Gas report

TransparentUpgradeableProxy

  • size: 0 / 49152
Method min mean median max calls
mintAndSupply(uint256) 217031 217071 217067 217115 3
withdrawAndBurn(uint256) 158111 158147 158159 158159 4

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈 Test Results 
No files changed, compilation skipped

Ran 3 tests for test/Lido_GHODirectMinter.t.sol:Lido_GHODirectMinter_Test
[PASS] test_mintAndSupply(uint256) (runs: 256, μ: 225286, ~: 224997)
[PASS] test_transferExcessToTreasury() (gas: 814312)
Logs:
  Bound result 1000000000000000000000

[PASS] test_withdrawAndBurn(uint256,uint256) (runs: 256, μ: 272450, ~: 272438)
Suite result: ok. 3 passed; 0 failed; 0 skipped; finished in 667.44ms (532.41ms CPU time)

Ran 1 test suite in 672.63ms (667.44ms CPU time): 3 tests passed, 0 failed, 0 skipped (3 total tests)

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Build logs 
Compiling 110 files with Solc 0.8.28
installing solc version "0.8.28"
Successfully installed solc 0.8.28
Solc 0.8.28 finished in 2.38s
Compiler run successful!
| Contract                            | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveV3Ethereum                      |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumAssets                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumEModes                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumExternalLibraries     |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLido                  |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoAssets            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoEModes            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoExternalLibraries |               85 |               135 |             24,491 |              49,017 |
| Address                             |               85 |               135 |             24,491 |              49,017 |
| ChainHelpers                        |               85 |               135 |             24,491 |              49,017 |
| ChainIds                            |               85 |               135 |             24,491 |              49,017 |
| ConfiguratorInputTypes              |               85 |               135 |             24,491 |              49,017 |
| Create2Utils                        |              162 |               212 |             24,414 |              48,940 |
| Create2UtilsZkSync                  |              145 |               195 |             24,431 |              48,957 |
| DataTypes                           |               85 |               135 |             24,491 |              49,017 |
| ERC1967Proxy                        |              163 |               976 |             24,413 |              48,176 |
| ERC1967Utils                        |               85 |               135 |             24,491 |              49,017 |
| EngineFlags                         |               85 |               135 |             24,491 |              49,017 |
| Errors                              |            4,671 |             4,723 |             19,905 |              44,429 |
| GHODirectMinter                     |            3,533 |             4,696 |             21,043 |              44,456 |
| GovV3Helpers                        |            2,384 |             2,436 |             22,192 |              46,716 |
| GovV3StorageHelpers                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Arbitrum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Avalanche               |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3BNB                     |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Base                    |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Ethereum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Gnosis                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Metis                   |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Optimism                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Polygon                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3PolygonZkEvm            |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Scroll                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3ZkSync                  |               85 |               135 |             24,491 |              49,017 |
| IpfsUtils                           |               85 |               135 |             24,491 |              49,017 |
| LidoGHOListing                      |            9,147 |             9,217 |             15,429 |              39,935 |
| MiscEthereum                        |               85 |               135 |             24,491 |              49,017 |
| PayloadsControllerUtils             |               85 |               135 |             24,491 |              49,017 |
| ProxyAdmin                          |            1,018 |             1,254 |             23,558 |              47,898 |
| ProxyHelpers                        |               85 |               135 |             24,491 |              49,017 |
| SafeERC20                           |               85 |               135 |             24,491 |              49,017 |
| StorageHelpers                      |               85 |               135 |             24,491 |              49,017 |
| StorageSlot                         |               85 |               135 |             24,491 |              49,017 |
| TestNetChainIds                     |               85 |               135 |             24,491 |              49,017 |
| TransparentUpgradeableProxy         |            1,115 |             2,206 |             23,461 |              46,946 |
| WadRayMath                          |               85 |               135 |             24,491 |              49,017 |

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔮 Coverage report
File Line Coverage Function Coverage Branch Coverage
src/GHODirectMinter.sol ${\color{green}100\%}$
$16 / 16$
 ${\color{green}100\%}$
$5 / 5$
 ${\color{red}50\%}$
$1 / 2$
src/proposals/LidoGHOListing.sol ${\color{green}100\%}$
$7 / 7$
 ${\color{red}50\%}$
$1 / 2$
LidoGHOListing.newListings 		${\color{green}100\%}$
$0 / 0$

Please sign in to comment.