Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update demo proposal #3

Merged
merged 1 commit into from
Dec 12, 2024
Merged

feat: update demo proposal #3

merged 1 commit into from
Dec 12, 2024

Conversation

sakulstra
Copy link
Contributor

No description provided.

Copy link

🔧 Build logs
Compiling 117 files with Solc 0.8.28
installing solc version "0.8.28"
Successfully installed solc 0.8.28
Solc 0.8.28 finished in 2.39s
Compiler run successful!
| Contract                            | Runtime Size (B) | Initcode Size (B) | Runtime Margin (B) | Initcode Margin (B) |
|-------------------------------------|------------------|-------------------|--------------------|---------------------|
| AaveV3Ethereum                      |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumAssets                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumEModes                |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumExternalLibraries     |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLido                  |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoAssets            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoEModes            |               85 |               135 |             24,491 |              49,017 |
| AaveV3EthereumLidoExternalLibraries |               85 |               135 |             24,491 |              49,017 |
| Address                             |               85 |               135 |             24,491 |              49,017 |
| ChainHelpers                        |               85 |               135 |             24,491 |              49,017 |
| ChainIds                            |               85 |               135 |             24,491 |              49,017 |
| ConfiguratorInputTypes              |               85 |               135 |             24,491 |              49,017 |
| Create2Utils                        |              162 |               212 |             24,414 |              48,940 |
| Create2UtilsZkSync                  |              145 |               195 |             24,431 |              48,957 |
| DataTypes                           |               85 |               135 |             24,491 |              49,017 |
| DeploymentLibrary                   |               85 |               135 |             24,491 |              49,017 |
| ERC1967Proxy                        |              163 |               976 |             24,413 |              48,176 |
| ERC1967Utils                        |               85 |               135 |             24,491 |              49,017 |
| EngineFlags                         |               85 |               135 |             24,491 |              49,017 |
| Errors                              |            4,671 |             4,723 |             19,905 |              44,429 |
| GhoDirectMinter                     |            4,555 |             6,026 |             20,021 |              43,126 |
| GovV3Helpers                        |            2,384 |             2,436 |             22,192 |              46,716 |
| GovV3StorageHelpers                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Arbitrum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Avalanche               |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3BNB                     |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Base                    |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Ethereum                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Gnosis                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Metis                   |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Optimism                |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Polygon                 |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3PolygonZkEvm            |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3Scroll                  |               85 |               135 |             24,491 |              49,017 |
| GovernanceV3ZkSync                  |               85 |               135 |             24,491 |              49,017 |
| IpfsUtils                           |               85 |               135 |             24,491 |              49,017 |
| LidoGHOListing                      |            4,058 |             4,258 |             20,518 |              44,894 |
| MiscEthereum                        |               85 |               135 |             24,491 |              49,017 |
| PayloadsControllerUtils             |               85 |               135 |             24,491 |              49,017 |
| ProxyAdmin                          |            1,018 |             1,254 |             23,558 |              47,898 |
| ProxyHelpers                        |               85 |               135 |             24,491 |              49,017 |
| ReserveConfiguration                |              169 |               219 |             24,407 |              48,933 |
| SafeERC20                           |               85 |               135 |             24,491 |              49,017 |
| StorageHelpers                      |               85 |               135 |             24,491 |              49,017 |
| StorageSlot                         |               85 |               135 |             24,491 |              49,017 |
| TestNetChainIds                     |               85 |               135 |             24,491 |              49,017 |
| TransparentUpgradeableProxy         |            1,115 |             2,206 |             23,461 |              46,946 |
| WadRayMath                          |               85 |               135 |             24,491 |              49,017 |

Copy link

🌈 Test Results
No files changed, compilation skipped

Ran 7 tests for test/Lido_GhoDirectMinter.t.sol:Lido_GHODirectMinter_Test
[PASS] test_mintAndSupply_council(uint256) (runs: 256, μ: 238481, ~: 238209)
[PASS] test_mintAndSupply_owner(uint256) (runs: 256, μ: 236248, ~: 236332)
[PASS] test_mintAndSupply_rando() (gas: 18197)
[PASS] test_transferExcessToTreasury() (gas: 851485)
Logs:
  Bound result 1000000000000000000000

[PASS] test_withdrawAndBurn_council(uint256,uint256) (runs: 256, μ: 309059, ~: 309252)
[PASS] test_withdrawAndBurn_owner(uint256,uint256) (runs: 256, μ: 304410, ~: 304997)
[PASS] test_withdrawAndBurn_rando() (gas: 18097)
Suite result: ok. 7 passed; 0 failed; 0 skipped; finished in 41.83s (8.96s CPU time)

Ran 1 test suite in 41.83s (41.83s CPU time): 7 tests passed, 0 failed, 0 skipped (7 total tests)

Copy link

Gas report

TransparentUpgradeableProxy

  • size: 2490 / 49152
Method min mean median max calls
fallback() 663 107808 172587 211805 26

GhoDirectMinter

  • size: 6122 / 49152
Method min mean median max calls
COLLECTOR() 227 227 227 227 2
GHO_A_TOKEN() 270 270 270 270 7
initialize(address,address) 72313 72313 72313 72313 7
mintAndSupply(uint256) 4853 211966 231250 231250 13
transferExcessToTreasury() 102813 102813 102813 102813 1
withdrawAndBurn(uint256) 4786 150373 166305 168512 10

LidoGHOListing

  • size: 4290 / 49152
Method min mean median max calls
FACILITATOR() 259 259 259 259 14
GHO_MINT_AMOUNT() 225 225 225 225 12
execute() 453959 453959 453959 453959 7

Copy link

🔮 Coverage report
File Line Coverage Function Coverage Branch Coverage
src/GhoDirectMinter.sol ${\color{green}100\%}$
$22 / 22$
${\color{green}100\%}$
$5 / 5$
${\color{red}50\%}$
$1 / 2$
src/proposals/LidoGHOListing.sol ${\color{green}100\%}$
$7 / 7$
${\color{green}100\%}$
$2 / 2$
${\color{green}100\%}$
$0 / 0$

@sakulstra sakulstra merged commit eb0af96 into main Dec 12, 2024
2 checks passed
@sakulstra sakulstra deleted the feat/update-demo-proposal branch December 12, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant