fix: remove arbitrum goerli (#361)

goerli.abiscan no longer exists and alchemy no longer allows creating endpoint.
therefore we consider it deprecated. goerli mainnet will follow shortly.

README.md

@@ -6,6 +6,8 @@ This repository contains an up-to-date registry of all addresses of the Aave eco
 
 The goal is for Solidity developers to have the most integrated environment possible when they want to develop on top of Aave, by just importing a package with all the necessary addresses to interact with.
 
+You can find a searchable version of the address book on [https://book.onaave.com/](https://book.onaave.com/).
+
 ## Usage with foundry
 
 With Foundry installed and being in a Git repository:
@@ -69,7 +71,7 @@ console.log(AaveV2Avalanche.CHAIN_ID);
 
 ### Generate files
 
-The library is generated based on the config file located in `scripts/generateAddresses.ts` and `scripts/generateABIs.ts`. You can regenerate the files by running `yarn start`.
+The library is generated based on the `scripts/generateAddresses.ts` and `scripts/generateABIs.ts` scripts. You can regenerate the files by running `yarn start`.
 
 ### Dependencies
 
@@ -91,7 +93,7 @@ forge test
 
 ### Adding a new Pool
 
-To list a new pool in the address book, you simply need to add a new pool in the respective [pools config](./scripts/configs/<type>/<network>) and run `yarn start`.
+To list a new pool in the address book, you simply need to add a new pool in the respective [pools config](./scripts/configs/<type>/<network>) and run `yarn generate:addresses`.
 
 ### Adding new Addresses
 
@@ -101,10 +103,6 @@ To achieve an addition here you need to add the address to the respective [v2 ty
 
 b) Adding an address that **cannot be obtained via onchain calls** so it needs to be manually maintained:
 
-To achieve an addition here, you need to alter the [additionalAddresses section](https://github.com/bgd-labs/aave-address-book/blob/main/scripts/config.ts#L46) on the pool type and add your address to the respecive pools. Additional addresses will currently be exported as type `address`. There's currently no possibility to define a custom type.
-
-In any case you need to run `yarn start` afterwards and commit the altered artifacts.
-
-## Sample projects
+To achieve an addition here, you need to alter the [additionalAddresses section](https://github.com/bgd-labs/aave-address-book/blob/main/scripts/config.ts#L46) on the pool type and add your address to the respective pools. Additional addresses will currently be exported as type `address`. There's currently no possibility to define a custom type.
 
-- [aave v2 asset listing template](https://github.com/bgd-labs/example-aave-v2-listing)
+In any case you need to run `yarn generate:addresses` afterwards and commit the altered artifacts.

scripts/configs/pools/arbitrum.ts

@@ -1,20 +1,6 @@
 import {ChainId} from '@bgd-labs/js-utils';
 import {PoolConfig} from '../types';
 
-export const arbitrumGoerliProtoV3: PoolConfig = {
-  name: 'ArbitrumGoerli',
-  chainId: ChainId.arbitrum_goerli,
-  POOL_ADDRESSES_PROVIDER: '0xD64dDe119f11C88850FD596BE11CE398CC5893e6',
-  additionalAddresses: {
-    FAUCET: '0xc1b3cc37cf2f922abDFE7F01A17bc932F4078665',
-    L2_ENCODER: '0x46605375317C3E8bd19E0ED70987354Cb6D16720',
-    UI_INCENTIVE_DATA_PROVIDER: '0x159E642e34ad712242F6057477277b093eb43950',
-    UI_POOL_DATA_PROVIDER: '0x1d5a0287E4ac7Ff805D8399D0177c75C8C95d4dC',
-    WALLET_BALANCE_PROVIDER: '0x8c7914af3926CfA5131Ce294c48E03C6d3aDc916',
-    WETH_GATEWAY: '0xcD1065F2c3A0e0a94d543Ce41720BFF515f753B7',
-  },
-};
-
 export const arbitrumProtoV3: PoolConfig = {
   name: 'Arbitrum',
   chainId: ChainId.arbitrum_one,

scripts/generateAddresses.ts

@@ -1,6 +1,6 @@
 import {appendFileSync, existsSync, mkdirSync, readdirSync, rmSync, writeFileSync} from 'fs';
 import {governanceConfigMainnet, governanceConfigGoerli} from './configs/governance/ethereum';
-import {arbitrumGoerliProtoV3, arbitrumProtoV3} from './configs/pools/arbitrum';
+import {arbitrumProtoV3} from './configs/pools/arbitrum';
 import {
   avalancheProtoV2,
   avalancheProtoV3,
@@ -120,7 +120,6 @@ async function main() {
       gnosisProtoV3,
       polygonZkEvmProtoV3,
       bnbProtoV3,
-      arbitrumGoerliProtoV3,
       arbitrumProtoV3,
       optimismGoerliProtoV3,
       optimismProtoV3,

scripts/generator/governanceV2Generator.ts

@@ -67,7 +67,10 @@ export function generateGovV2() {
   fs.writeFileSync(
     `./src/ts/AaveGovernanceV2.ts`,
     prefixWithGeneratedWarning(
-      generateJsConstants({chainId: ChainId.mainnet, addresses: govV2Addresses}).join('\n'),
+      generateJsConstants({
+        chainId: ChainId.mainnet,
+        addresses: {...govV2Addresses, CHAIN_ID: {value: 1, type: 'uint256'}},
+      }).join('\n'),
     ),
   );
 

src/AaveAddressBook.sol

@@ -36,7 +36,6 @@ import {AaveV3Metis} from './AaveV3Metis.sol';
 import {AaveV3Gnosis} from './AaveV3Gnosis.sol';
 import {AaveV3PolygonZkEvm} from './AaveV3PolygonZkEvm.sol';
 import {AaveV3BNB} from './AaveV3BNB.sol';
-import {AaveV3ArbitrumGoerli} from './AaveV3ArbitrumGoerli.sol';
 import {AaveV3Arbitrum} from './AaveV3Arbitrum.sol';
 import {AaveV3OptimismGoerli} from './AaveV3OptimismGoerli.sol';
 import {AaveV3Optimism} from './AaveV3Optimism.sol';

src/ts/AaveAddressBook.ts

@@ -33,7 +33,6 @@ export * as AaveV3Metis from './AaveV3Metis';
 export * as AaveV3Gnosis from './AaveV3Gnosis';
 export * as AaveV3PolygonZkEvm from './AaveV3PolygonZkEvm';
 export * as AaveV3BNB from './AaveV3BNB';
-export * as AaveV3ArbitrumGoerli from './AaveV3ArbitrumGoerli';
 export * as AaveV3Arbitrum from './AaveV3Arbitrum';
 export * as AaveV3OptimismGoerli from './AaveV3OptimismGoerli';
 export * as AaveV3Optimism from './AaveV3Optimism';