fix: seatbelt formatting patches

bitmap as binary ltv at % lb without -100%
bgd-labs · Oct 27, 2024 · b2073f6 · b2073f6
1 parent 165e9f0
commit b2073f6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/src/govv3/__snapshots__/generatePayloadReport.spec.ts.snap b/src/govv3/__snapshots__/generatePayloadReport.spec.ts.snap
@@ -256,11 +256,11 @@ InitializableImmutableAdminUpgradeabilityProxy at \`0xb50201558B00496A145fE76f74
 - "0x000000000000000000000000e07e26f316248a2aa14115439a0bd9ea49328dc7"
 + "0x0000000000000000000000008a48ef9287c402c119c14a5f6897f6dfdc12cb45"
 @@ \`_eModeCategories\` key \`1.collateralBitmap\` @@
-- 0
-+ 3
+- 0b0
++ 0b11
 @@ \`_eModeCategories\` key \`1.borrowableBitmap\` @@
-- 0
-+ 3
+- 0b0
++ 0b11
 @@ \`_eModeCategories\` key \`1.collateralBitmap_decoded\` @@
 - 
 + WETH(id: 0),wstETH(id: 1)

diff --git a/src/govv3/checks/state.ts b/src/govv3/checks/state.ts
@@ -145,13 +145,15 @@ export async function deepDiff({
           bitMapToIndexes(BigInt(before.collateralBitmap || 0)),
         )
       ).toString();
+      before.collateralBitmap = toBinaryString(BigInt(before.collateralBitmap || 0));
       after.collateralBitmap_decoded = (
         await assetIndexesToAsset(
           client,
           address,
           bitMapToIndexes(BigInt(after.collateralBitmap || 0)),
         )
       ).toString();
+      after.collateralBitmap = toBinaryString(BigInt(after.collateralBitmap || 0));
     }
     if (before.borrowableBitmap !== undefined) {
       before.borrowableBitmap_decoded = (
@@ -161,13 +163,15 @@ export async function deepDiff({
           bitMapToIndexes(BigInt(before.borrowableBitmap || 0)),
         )
       ).toString();
+      before.borrowableBitmap = toBinaryString(BigInt(before.borrowableBitmap || 0));
       after.borrowableBitmap_decoded = (
         await assetIndexesToAsset(
           client,
           address,
           bitMapToIndexes(BigInt(after.borrowableBitmap || 0)),
         )
       ).toString();
+      after.borrowableBitmap = toBinaryString(BigInt(after.borrowableBitmap || 0));
     }
   }
 
@@ -262,7 +266,7 @@ async function enhanceValue({
     if (key && ['_reserves', '_eModeCategories'].includes(type)) {
       if (['liquidityIndex', 'variableBorrowIndex'].includes(key))
         return prettifyNumber({decimals: 27, value, showDecimals: true});
-      if (['liquidationThreshold', 'reserveFactor', 'liquidationProtocolFee'].includes(key))
+      if (['liquidationThreshold', 'reserveFactor', 'liquidationProtocolFee', 'ltv'].includes(key))
         return prettifyNumber({decimals: 2, value, suffix: '%', showDecimals: true});
       if (
         ['currentLiquidityRate', 'currentVariableBorrowRate', 'currentStableBorrowRate'].includes(
@@ -276,7 +280,7 @@ async function enhanceValue({
           value,
           suffix: '%',
           showDecimals: true,
-          patchedValue: BigInt(value) - BigInt(1e4),
+          patchedValue: BigInt(value) == 0n ? 0n : BigInt(value) - BigInt(1e4),
         });
     }
   }
@@ -324,3 +328,7 @@ export const checkStateChanges: ProposalCheck<any> = {
     return {info, warnings, errors};
   },
 };
+
+function toBinaryString(value: bigint) {
+  return `0b` + value.toString(2);
+}