AaveSwapper: Add test scripts #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/swaps/scripts/TestSwap.s.sol
Outdated
| import {AaveSwapper} from 'src/swaps/AaveSwapper.sol'; | ||
|
|
||
| // make test-swap | ||
| contract TestSwap is EthereumScript { |
There was a problem hiding this comment.
I would put the script in the ./scripts directory instead of ./src/swaps/scripts
src/swaps/scripts/TestSwap.s.sol
Outdated
| @@ -0,0 +1,69 @@ | |||
| // SPDX-License-Identifier: MIT | |||
|
|
|||
| pragma solidity 0.8.18; | |||
There was a problem hiding this comment.
Suggested change
| pragma solidity 0.8.18; | |
| pragma solidity ^0.8.0; |
|
Could you also update the libraries to the latest version (aave-address-book) or update with the latest |
|
@brotherlymite updated! |
sendra
reviewed
Oct 29, 2024
| @@ -41,8 +41,8 @@ contract AaveSwapper is Initializable, OwnableWithGuardian, Rescuable { | |||
| address public constant BAL80WETH20 = 0x5c6Ee304399DBdB9C8Ef030aB642B10820DB8F56; | |||
|
|
|||
| function initialize() external initializer { | |||
| _transferOwnership(AaveGovernanceV2.SHORT_EXECUTOR); | |||
| _updateGuardian(0xA519a7cE7B24333055781133B13532AEabfAC81b); | |||
| _transferOwnership(0x3765A685a401622C060E5D700D9ad89413363a91); | |||
There was a problem hiding this comment.
what are these addresses? Should this be taken from address book? Provably should be passed as params though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Update README with instructions to perform live test.
Add scripts to easily test with owned set up.