-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add TransparentProxyFactoryBase (#37)
* Add TransparentProxyFactoryBase * cleanup ITransparentProxyFactoryZkSync
- Loading branch information
Showing
4 changed files
with
97 additions
and
187 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
src/contracts/transparent-proxy/TransparentProxyFactoryBase.sol
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity >=0.8.0; | ||
|
||
import {IOwnable} from './interfaces/IOwnable.sol'; | ||
import {ITransparentProxyFactory} from './interfaces/ITransparentProxyFactory.sol'; | ||
import {TransparentUpgradeableProxy} from './TransparentUpgradeableProxy.sol'; | ||
import {ProxyAdmin} from './ProxyAdmin.sol'; | ||
|
||
/** | ||
* @title TransparentProxyFactory | ||
* @author BGD Labs | ||
* @notice Factory contract to create transparent proxies, both with CREATE and CREATE2 | ||
* @dev `create()` and `createDeterministic()` are not unified for clearer interface, and at the same | ||
* time allowing `createDeterministic()` with salt == 0 | ||
* @dev Highly recommended to pass as `admin` on creation an OZ ProxyAdmin instance | ||
**/ | ||
abstract contract TransparentProxyFactoryBase is ITransparentProxyFactory { | ||
/// @inheritdoc ITransparentProxyFactory | ||
function create( | ||
address logic, | ||
address admin, | ||
bytes calldata data | ||
) external returns (address) { | ||
address proxy = address(new TransparentUpgradeableProxy(logic, admin, data)); | ||
|
||
emit ProxyCreated(proxy, logic, admin); | ||
return proxy; | ||
} | ||
|
||
/// @inheritdoc ITransparentProxyFactory | ||
function createProxyAdmin(address adminOwner) external returns (address) { | ||
address proxyAdmin = address(new ProxyAdmin()); | ||
IOwnable(proxyAdmin).transferOwnership(adminOwner); | ||
|
||
emit ProxyAdminCreated(proxyAdmin, adminOwner); | ||
return proxyAdmin; | ||
} | ||
|
||
/// @inheritdoc ITransparentProxyFactory | ||
function createDeterministic( | ||
address logic, | ||
address admin, | ||
bytes calldata data, | ||
bytes32 salt | ||
) external returns (address) { | ||
address proxy = address(new TransparentUpgradeableProxy{salt: salt}(logic, admin, data)); | ||
|
||
emit ProxyDeterministicCreated(proxy, logic, admin, salt); | ||
return proxy; | ||
} | ||
|
||
/// @inheritdoc ITransparentProxyFactory | ||
function createDeterministicProxyAdmin(address adminOwner, bytes32 salt) | ||
external | ||
returns (address) | ||
{ | ||
address proxyAdmin = address(new ProxyAdmin{salt: salt}()); | ||
IOwnable(proxyAdmin).transferOwnership(adminOwner); | ||
|
||
emit ProxyAdminDeterministicCreated(proxyAdmin, adminOwner, salt); | ||
return proxyAdmin; | ||
} | ||
|
||
/// @inheritdoc ITransparentProxyFactory | ||
function predictCreateDeterministic( | ||
address logic, | ||
address admin, | ||
bytes calldata data, | ||
bytes32 salt | ||
) public view virtual returns (address); | ||
|
||
/// @inheritdoc ITransparentProxyFactory | ||
function predictCreateDeterministicProxyAdmin(bytes32 salt) public view virtual returns (address); | ||
} |