Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for vercel.com/templates #1442

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

malewis5
Copy link
Contributor

What/Why?

When published on the Vercel templates page we use the README for the template description. It doesn't support Github markdown language so the "Important" highlighting needed to be changed. We also don't support relative links so all links have absolute paths.

Testing

With these new changes the description on vercel.com/templates should look correct and the Deploy button on the README should successfully deploy a project to Vercel.

@malewis5 malewis5 requested a review from a team as a code owner October 10, 2024 16:27
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: 1f667b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 10, 2024

@malewis5 is attempting to deploy a commit to the BigCommerce Platform Team on Vercel.

A member of the Team first needs to authorize it.

@malewis5
Copy link
Contributor Author

Please do not merge.

@malewis5 malewis5 changed the title Update README for vercel.com/templates DO NOT MERGE: Update README for vercel.com/templates Oct 10, 2024
@malewis5
Copy link
Contributor Author

Ready to merge.

@malewis5 malewis5 changed the title DO NOT MERGE: Update README for vercel.com/templates Update README for vercel.com/templates Oct 13, 2024
Copy link
Contributor

@chanceaclark chanceaclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me but I am going to differ to @matthewvolk for approval/merge.

> [!IMPORTANT]
> If you just want to build a storefront, start with the [CLI](#quickstart) which will install the Next.js application in [/core](/core/).
> **Important:**
> If you just want to build a storefront, start with the [CLI](#quickstart) which will install the Next.js application in [/core](https://github.com/bigcommerce/catalyst/tree/main/core).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewvolk shouldn't this be the root monorepo now instead of /core?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct! Let's maybe change it to:

Suggested change
> If you just want to build a storefront, start with the [CLI](#quickstart) which will install the Next.js application in [/core](https://github.com/bigcommerce/catalyst/tree/main/core).
> If you just want to build a storefront, start with the [CLI](#quickstart) which will install the [entire Catalyst repository](https://github.com/bigcommerce/catalyst) locally.

When published to Vercel templates the README is used for the description. I updated some links and syntax so the description will show up correctly.
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview Dec 9, 2024 6:07pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 6:07pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 6:07pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 6:07pm

@chanceaclark
Copy link
Contributor

Not sure where we are at here, but wanted to check in. @malewis5 and @matthewvolk do we need anything to move this forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants