James/vib 814

[jamesqquick]

What/Why?

Text on add to cart button should be localized inside of the ProductDetail component.

Testing

• enable a secondary local in /core/i18n/routing.ts like 'es'
• Navigate to a PDP and prefix the URL /es/
• button text should change

CleanShot.2024-11-07.at.14.12.30.mp4

[linear]

VIB-814 Add internationalization labels for ProductDetails

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4b735e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
catalyst	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 5:33pm
catalyst-latest	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 5:33pm
catalyst-soul	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 8, 2024 5:33pm
catalyst-unstable	❌ Failed (Inspect)			Nov 8, 2024 5:33pm

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
catalyst-1millionproducts-store	⬜️ Ignored (Inspect)	Visit Preview		Nov 8, 2024 5:33pm
catalyst-au	⬜️ Ignored (Inspect)	Visit Preview		Nov 8, 2024 5:33pm
catalyst-uk	⬜️ Ignored (Inspect)	Visit Preview		Nov 8, 2024 5:33pm

[migueloller]

Looks good 👍🏻

[migueloller]

Looks good @jamesqquick. You'll have to rebase ad resolve the conflict, though.

[jamesqquick]

@migueloller done! I don't know if I'm allowed to merge or not lol I'll wait for you. If I need to rebase again in the morning I will

[github-actions]

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-hl8lhffbn-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category	Score
🟠 Performance	77
🟠 Accessibility	78
🟢 Best practices	100
🟠 SEO	82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category	Score
🟠 Performance	64
🟠 Accessibility	78
🟢 Best practices	100
🟠 SEO	83

[migueloller]

@migueloller done! I don't know if I'm allowed to merge or not lol I'll wait for you. If I need to rebase again in the morning I will

If it’s all green, go for it!