Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom blog url routing, update blog tag filtering, delete /blog/tag/[tagId] route #1797

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

jordanarldt
Copy link

@jordanarldt jordanarldt commented Dec 20, 2024

What/Why?

  • Add support for custom blog URL routing - we were generating links to the blog based on the BC URL for the blog index, but had no routing for it.
  • Now that custom blog URL routing will work, we needed to refactor blog tag filtering to be a query parameter
  • Delete /blog/tag/[tagId] route (replaced with /blog?tag=[tag] query param

Testing

Blog posts, blog index, tag filtering, and blog pagination all work as expected:

Screen.Recording.2024-12-20.at.5.11.37.PM.mov

@jordanarldt jordanarldt requested a review from a team as a code owner December 20, 2024 21:47
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 78e2a9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
catalyst-latest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:12pm
catalyst-soul ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 11:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
catalyst ⬜️ Ignored (Inspect) Dec 20, 2024 11:12pm
catalyst-au ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 11:12pm
catalyst-uk ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 11:12pm

Copy link
Collaborator

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we should use nuqs for search param parsing and serialization to avoid things blowing up when encountering an unexpected value for the tag search param (e.g., passing multiple tags or passing an empty value, etc.)

core/app/[locale]/(default)/blog/page.tsx Outdated Show resolved Hide resolved
@jordanarldt jordanarldt merged commit 02ffe78 into soul/main Dec 23, 2024
12 of 14 checks passed
@jordanarldt jordanarldt deleted the ja/fix-blog-routing branch December 23, 2024 15:48
Copy link
Contributor

⚡️🏠 Lighthouse report

Lighthouse ran against https://catalyst-latest-mtyi0v99d-bigcommerce-platform.vercel.app

🖥️ Desktop

We ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:

Category Score
🟢 Performance 97
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 82

📱 Mobile

We ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:

Category Score
🟠 Performance 81
🟢 Accessibility 92
🟢 Best practices 100
🟠 SEO 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants