-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom blog url routing, update blog tag filtering, delete /blog/tag/[tagId] route #1797
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I think we should use nuqs
for search param parsing and serialization to avoid things blowing up when encountering an unexpected value for the tag
search param (e.g., passing multiple tags or passing an empty value, etc.)
2eb8d77
to
ebb5c71
Compare
ebb5c71
to
f926215
Compare
…ing, delete /blog/tag/[tagId] route
f926215
to
78e2a9b
Compare
⚡️🏠 Lighthouse reportLighthouse ran against https://catalyst-latest-mtyi0v99d-bigcommerce-platform.vercel.app 🖥️ DesktopWe ran Lighthouse against the changes on a desktop and produced this report. Here's the summary:
📱 MobileWe ran Lighthouse against the changes on a mobile and produced this report. Here's the summary:
|
What/Why?
/blog/tag/[tagId]
route (replaced with/blog?tag=[tag]
query paramTesting
Blog posts, blog index, tag filtering, and blog pagination all work as expected:
Screen.Recording.2024-12-20.at.5.11.37.PM.mov