Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix the import issue that's causing ModuleNotFoundError #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

javanhut
Copy link

@javanhut javanhut commented Dec 1, 2024

Thanks for sending a pull request!
Please make sure you click the link above to view the contribution guidelines,
then fill out the blanks below.

Description

Basically if you download or install this Edudata a module not found error occurs for the longling.ML and longling.lib for two files.

What does this implement/fix? Explain your changes.

... The imports haven't been updated to the current longling repo. So i updated them to used the edudata in general.
added the update to the EduData/main.py file and the EduData/Dataset/junyi/KnowledgeTracing.py
Now the edudata cli works. Pretty big deal if you want to download the dataset for training an ml model.

Pull request type

  • [DATASET] Add a new dataset
  • [BUGFIX] Bugfix
  • [FEATURE] New feature (non-breaking change which adds functionality)
  • [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [STYLE] Code style update (formatting, renaming)
  • [REFACTOR] Refactoring (no functional changes, no api changes)
  • [BUILD] Build related changes
  • [DOC] Documentation content changes
  • [OTHER] Other (please describe):

Changes

  • Fix: Updated imports to fix modulenotfound error.

Does this close any currently open issues?

... No clue didn't bother to look.

Any relevant logs, error output, etc?

... I could add those but i'm not going to.

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage and al tests passing
  • Code is well-documented (extended the README / documentation, if necessary)
  • If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • It's a needed import update and it annoyed me so i fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant