Correct a comment and a typo #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spawn is about executing something inside the sandbox. There is a different interface for executing outside.
|
I don't plan to do a new .x release anytime soon, so it is fine to break API. As we would bump to zbus 4.0 soon-ish anyways |
|
If you need the fixed version, you can always cherry-pick the changes and mark the wrongly named one as deprecated in the 0.6 branch |
|
That's all fine then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first change is that
Spawnis not about running things outside the sandbox but inside. There is a different interface for running processes outside of the sandbox.The second one is an all-to-common typo of writing
existedinstead ofexited. This does break API but it also fixes it so I don't know what you'd want to do about accepting that. Maybe the typoed version should be deprecated instead?