window_identifier: from_native with wayland only #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not require gtk4 feature to be enabled for WindowIdentifier::from_native to allow to use this feature with only wayland enabled. Closes bilelmoussaoui#171
sophie-h
force-pushed
the
wip/sophie-h/from-native
branch
from
c51f432 to
9b98d39
Compare
|
Okay, this still seems to build in all constellations and I also tested it with gtk4_wayland in Loupe. I have not touched the raw_handle part since this seems to be a bit more work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not require gtk4 feature to be enabled for
WindowIdentifier::from_native to allow to use this feature with only wayland enabled.
Closes #171