WIP: add backend support #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
bilelmoussaoui
force-pushed
the
bilelmoussaoui/backend
branch
from
b19a5f2 to
419f933
Compare
i509VCB
reviewed
Oct 14, 2022
| window_identifier: WindowIdentifierType, | ||
| options: UserInfoOptions, | ||
| ) -> Response<UserInfo> { | ||
| Response::Err(ResponseError::Cancelled) |
There was a problem hiding this comment.
Is there a reason Response is like Result instead of modeling the apis around returning a request::Result type which typedefs the Result type?
There was a problem hiding this comment.
The main reason was the custom deserialize/serialize that are needed for Response; we can always make that an internal implementation.
bilelmoussaoui
force-pushed
the
bilelmoussaoui/backend
branch
from
419f933 to
db12d2b
Compare
|
Closing in favor of #108 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.