suppress prom invalid label value problem (#118)

* suppress prom invalid label value problem * Extend the fetch interval to once a week
bilibili · Feb 24, 2020 · 3ef42d6 · 3ef42d6
1 parent 53c057f
commit 3ef42d6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/prom/prom.go b/pkg/prom/prom.go
@@ -83,6 +83,7 @@ func ProxyTime(cluster, node string, ts int64) {
 	if proxyTimer == nil {
 		return
 	}
+	node = ""
 	proxyTimer.WithLabelValues(cluster, node).Observe(float64(ts))
 }
 
@@ -91,6 +92,7 @@ func HandleTime(cluster, node, cmd string, ts int64) {
 	if handlerTimer == nil {
 		return
 	}
+	cmd = ""
 	handlerTimer.WithLabelValues(cluster, node, cmd).Observe(float64(ts))
 }
 
@@ -99,6 +101,7 @@ func ErrIncr(cluster, node, cmd, err string) {
 	if gerr == nil {
 		return
 	}
+	cmd = ""
 	gerr.WithLabelValues(cluster, node, cmd, err).Inc()
 }
 

diff --git a/proxy/proto/redis/cluster/cluster.go b/proxy/proto/redis/cluster/cluster.go
@@ -148,7 +148,7 @@ func (c *cluster) fetchproc() {
 	for {
 		select {
 		case <-c.action:
-		case <-time.After(30 * time.Minute):
+		case <-time.After(7 * 24 * time.Hour):
 		}
 		c.tryFetch()
 		time.Sleep(time.Second)