fix msg done before prometheus

bilibili · Mar 21, 2019 · b41826d · b41826d
1 parent ad50cd1
commit b41826d
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/proxy/proto/pipe.go b/proxy/proto/pipe.go
@@ -174,14 +174,14 @@ func (mp *msgPipe) pipe() {
 		for i := 0; i < mp.count; i++ {
 			msg := mp.batch[i]
 			msg.WithError(err) // NOTE: maybe err is nil
-			msg.Done()
 			if prom.On {
 				if err != nil {
 					prom.ErrIncr(nc.Cluster(), nc.Addr(), msg.Request().CmdString(), perr.Cause(err).Error())
 				} else {
 					prom.HandleTime(nc.Cluster(), nc.Addr(), msg.Request().CmdString(), int64(msg.RemoteDur()/time.Microsecond))
 				}
 			}
+			msg.Done()
 		}
 		mp.count = 0
 		if err != nil {