fix: append all split FASTA files to the list for TRF execution #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We welcome feedback and issue reporting for all bioBakery tools through our Discourse site. For users that would like to directly contribute to the tools we are happy to field PRs to address bug fixes. Please note the turn around time on our end might be a bit long to field these but that does not mean we don't value the contribution! We currently don't accept PRs to add new functionality to tools but we would be happy to receive your feedback on Discourse.
Also, we will make sure to attribute your contribution in our User’s manual(README.md) and in any associated paper Acknowledgements.
Description
The size of the output FASTQ file is different when the
-targument is greater then 1.I found that it might be caused by line 124 in kneaddata/trf_parallel.py
Since
file_handle_writeis always not None after the file is opened(line 124), only the first temporary file is appended to thetempfile_written_listanddatfile_to_write_list(line 115~116). As a result, the trf command actually executes only one parallel temporary file.Related Issue
Screenshots (if appropriate):