-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added receipe for bdgenomics.mango #17960
Conversation
Welcome to Bioconda, @akmorrow13! Thank you for opening your first pull request! As you're new to Bioconda, please read through our documentation about contributing recipes. If you need help, please ping one of the following teams:
You can also join our Gitter channel to find help. Please ping If you would like to join Bioconda, please mention that to |
Package(s) built on CircleCI are ready for inspection:
You may also use
Docker image(s) built:
|
You'll need to add the various bdgenomics dependencies. |
The current error message is:
Looks like "mango-submit" is using "find-mango-assembly.sh" which is not symlinked to |
I've fixed the initial set of problems, though this points out some real oddities in how the software is structured. |
We ran into similar issues with how conda breaks apart our tarballs with symlinks in the Bioconda recipe for adam. The workarounds and patches there are still not entirely satisfactory, see e.g. bigdatagenomics/adam#2225. Do you have any suggestions as to how to better structure our release artifacts? |
@dpryan79 would you know why $SP_DIR is set correctly during the initial test phase but is no longer set correctly during the mulled-build build-and-test phase? This description of conda variables says that SP_DIR should also be set during test. |
There's no |
@heuermh The occasional symlink shouldn't be an issue. The structure problem with the packages seems to be that the jar files aren't being properly installed with pip. They should be treated as data files (to use python lingo). |
Bioconda requires reviews prior to merging pull-requests (PRs). To facilitate this, once your PR is passing tests and ready to be merged, please add the
please review & merge
label so other members of the bioconda community can have a look at your PR and either make suggestions or merge it. Note that if you are not already a member of the bioconda project (meaning that you can't add this label), please ping@bioconda/core
so that your PR can be reviewed and merged (please note if you'd like to be added to the bioconda project). Please see #15332 for more details.