Fix neighbors/outgoing/ingoing with weights=False #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Methods that return neighbours or ingoing or outgoing connections fail if
weights=True
. This code was obviously never used and never tested.Network widgets are in dire need of unit tests. :(
Description of changes
A fix would be to add a pair of parentheses (
vstack
expects a tuple, not multiple arguments).However, node indices are ints and weights are floats, so we should put them into the same array. Instead, the function now returns a tuple. Since nobody could have used the code, we need not care about backward compatibility.
Includes