Merge pull request #900 from PrimozGodec/shared-cv-remove-var

[FIX] VectorizationComputeValue - remove wrongly set "original" variable
biolab · Sep 2, 2022 · 01544ed · 01544ed
2 parents 339ad59 + e85e2c7
commit 01544ed
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/orangecontrib/text/corpus.py b/orangecontrib/text/corpus.py
@@ -320,8 +320,6 @@ def _rename_features(additional_names: List) -> Tuple[List, List, List]:
             else:
                 var = ContinuousVariable(f, compute_value=cv)
             var.sparse = sparse     # don't pass this to constructor so this works with Orange < 3.8.0
-            if cv is not None:      # set original variable for cv
-                cv.variable = var
             if isinstance(var_attrs, dict):
                 var.attributes.update(var_attrs)
             additional_attributes.append(var)

diff --git a/orangecontrib/text/vectorization/bagofwords.py b/orangecontrib/text/vectorization/bagofwords.py
@@ -88,10 +88,8 @@ def _transform(self, corpus, source_dict=None, callback=dummy_callback):
         callback(0.9)
 
         # set compute values
-        shared_cv = SharedTransform(self, corpus.used_preprocessor,
-                                    source_dict=dic)
-        cv = [VectorizationComputeValue(shared_cv, dic[i])
-              for i in range(len(dic))]
+        shared_cv = SharedTransform(self, corpus.used_preprocessor, source_dict=dic)
+        cv = [VectorizationComputeValue(shared_cv, dic[i]) for i in range(len(dic))]
 
         corpus = self.add_features(corpus, X, dic, cv, var_attrs={'bow-feature': True})
         callback(1)