Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text processing module with slow internet conection #519

Closed
pavelbs opened this issue Apr 29, 2020 · 10 comments · Fixed by #524
Closed

text processing module with slow internet conection #519

pavelbs opened this issue Apr 29, 2020 · 10 comments · Fixed by #524
Assignees

Comments

@pavelbs
Copy link

pavelbs commented Apr 29, 2020

textprocessingerr.txt

Hi! I have slow internet connection, less than 400Kbit/s. And when I use text preprocessing module I have an error.
If I disconnect my internet connection (disable wifi), the text processing module works fine.
If I have have internet connection more than 3Mbit/s, everything works fine.

Text version 0.9/0.8
Orange version 3.26/3.25
@ajdapretnar
Copy link
Collaborator

Thanks for reporting this, we will have a look.

@PrimozGodec
Copy link
Collaborator

PrimozGodec commented May 4, 2020

Hi @pavelbs, I tried to reproduce your error. I used the Network Link Conditioner to simulated a bad connection (different speeds, package lost rates, delays). I couldn't reproduce the particular error. It seems that in your case the text which is retrieved from the server is somehow corrupted, even the response from the server is 200 (OK). We can try to catch this particular error anyway. I am just interested in whether this error happens every time you try to load the Preprocess Text widget?

Btw. we have another issue with the Preprocess text widget. If I limit connection to much, it takes forever to load the widget. It seems that there is no reasonable timeout set. I will recheck this issue when #506 is merged since it does not make sense to fix it.

@pavelbs
Copy link
Author

pavelbs commented May 4, 2020

This error occurs every time I try to load the Preprocess Text widget. I live in a small village. My nearest cell tower is 20 km from me. I have 3G amplifier from aliexpress + 3G wifi router and handmade 3G antenna.
(Orange38) [pavelbs@pavelbs-pc-manjaro orange3]$ ping mail.ru
PING mail.ru (94.100.180.201) 56(84) bytes of data.
64 bytes from mail.ru (94.100.180.201): icmp_seq=1 ttl=47 time=118 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=2 ttl=47 time=199 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=3 ttl=47 time=158 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=4 ttl=47 time=190 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=5 ttl=47 time=148 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=6 ttl=47 time=158 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=7 ttl=47 time=149 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=8 ttl=47 time=315 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=9 ttl=47 time=167 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=10 ttl=47 time=136 ms
64 bytes from mail.ru (94.100.180.201): icmp_seq=11 ttl=47 time=155 ms

@PrimozGodec
Copy link
Collaborator

@pavelbs thank you for your fast response. We are not completely sure that the error is caused by the slow connection (but it is possible anyway). We would like to inspect your problem further, so we ask you if you can run the script attached to this comment and paste us the pickle file that it generates. It will give us an idea of what is happening with the response in your case.

example.py.zip

@pavelbs
Copy link
Author

pavelbs commented May 7, 2020

done
response.pkl.zip

@PrimozGodec
Copy link
Collaborator

@pavelbs thank you. This reveals the reason behind the error. Can I just ask you for another test? I changed the script a bit can you run it and send me a response? I just want to know if our assumptions are correct.

example1.py.zip

@pavelbs
Copy link
Author

pavelbs commented May 7, 2020

done
response.pkl.zip

@PrimozGodec
Copy link
Collaborator

PrimozGodec commented May 7, 2020

@pavelbs thank you for your help. The issue was not a slow internet connection but the fact that we were reaching our server through HTTP instead of https and your internet provider replaced a 404 (not reachable) response with a fancy HTML page. Using HTTPS solves the issue. I made a PR with the fix.

@pavelbs
Copy link
Author

pavelbs commented May 7, 2020

What should I do?

@PrimozGodec
Copy link
Collaborator

Nothing needs to be done from your side. I prepared a pull request with the fix, someone, from the team will merge it soon #524.
When it will be merged and the add-on will be released you can use a preprocess widget normally.
If you want to use this fix earlier you would need to clone this addon and install it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants