Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update ulr to use https for udpipe models #524

Merged
merged 1 commit into from
May 22, 2020

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Fixes #519

Description of changes

The issue was that we were using HTTP and when 404 happened the internet provider can replace 404 responses with something else. It can be avoided with https

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #524 into master will decrease coverage by 0.29%.
The diff coverage is 4.65%.

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   66.93%   66.63%   -0.30%     
==========================================
  Files          66       66              
  Lines        7137     7169      +32     
  Branches      948      949       +1     
==========================================
  Hits         4777     4777              
- Misses       2205     2237      +32     
  Partials      155      155              

@ajdapretnar
Copy link
Collaborator

I think you need to rebase this. It looks like you have pull in some of @djukicn changes. :)

@PrimozGodec PrimozGodec force-pushed the fix-preprocess-json-err branch from 0626afb to 1344390 Compare May 8, 2020 11:23
@PrimozGodec
Copy link
Collaborator Author

I accidentally based the PR on wrong branch. Now it is fixed.

@ajdapretnar ajdapretnar merged commit 32d82f4 into biolab:master May 22, 2020
@PrimozGodec PrimozGodec deleted the fix-preprocess-json-err branch March 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

text processing module with slow internet conection
3 participants