[ENH] Corpus & Bow: Improve sparsity handling according to Orange>=3.8.0 #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
BoW features when comming from compute values were dense, when some features already existed in the corpus. The core of the problems is bad logic for deciding on the sparsity, which was fixed in biolab/orange3#2341 and released in
Orange=3.8.0
.Description of changes
Orange=3.8.0
.IMPORTANT: Orange version in
requirements.txt
wasn't bumped to3.8.0
on purpuse and the code was written in a backwards comparible manner so that the addon can also work with older versions of Orange. Note, however, that it is higly recommended to update Orange to>=3.8.0
since as of this PR the BoW data on older Orange versions will become dense!Includes