Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Table Input to Corpus #308

Merged
merged 4 commits into from
Aug 25, 2017
Merged

Conversation

nikicc
Copy link
Contributor

@nikicc nikicc commented Aug 18, 2017

Issue

One cannot convert Orange's data table to Corpus instance.

Description of changes
  • OWCorpus now has Table input. When present, some GUI elements are frozen and the data from the input is considered.
  • Raise an error when corpus has not textual features.
  • Raise an error when no text features are selected.
  • CorpusViewer now accepts Corpus, not Table.
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 18, 2017

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          34       34           
  Lines        1825     1825           
  Branches      333      333           
=======================================
  Hits         1552     1552           
  Misses        238      238           
  Partials       35       35

@nikicc nikicc changed the title [ENH] Add Data Input to Corpus [ENH] Add Table Input to Corpus Aug 18, 2017
@nikicc nikicc force-pushed the corpus-add-data-input branch from ff1c3e1 to 521f178 Compare August 18, 2017 13:12
@lanzagar
Copy link
Contributor

Context settings for lists of variables need to be handled correctly (in this widget and others) - planned for a separate PR.

@lanzagar lanzagar merged commit 9e72bd7 into biolab:master Aug 25, 2017
@lanzagar
Copy link
Contributor

Ah, merged it a little too quickly.
I overlooked that you are changing the input type for Corpus Viewer and don't insure backwards compatibility for saved workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants